Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adjust wallet-button styling + add logo-href #1411

Open
wants to merge 170 commits into
base: develop
Choose a base branch
from

Conversation

dennyscode
Copy link
Contributor

Copy link
Contributor

@oktapodia oktapodia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Oct 16, 2024

Playwright test results

passed  11 passed
skipped  3 skipped

Details

stats  14 tests across 2 suites
duration  1 minute, 54 seconds
commit  cc3b44e

Skipped tests

chromium › e2e.spec.ts › Jumper full e2e flow › Should be able to navigate to profile and open first Mission
chromium › e2e.spec.ts › Jumper full e2e flow › Should be able to navigate to Supefest
chromium › e2e.spec.ts › Jumper full e2e flow › Should be able to open quests mission page and switch background color

Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jumper-exchange ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 4:05pm

@tcheee
Copy link
Contributor

tcheee commented Oct 16, 2024

image I still have an issue when my wallet is not connected

Base automatically changed from ft/beta-testing/1 to develop October 17, 2024 08:56
@dennyscode
Copy link
Contributor Author

@tcheee What do you think about adding a tooltip for more context of those new icons?
Screenshot 2024-10-17 at 16 20 48

padding: '16px',
paddingTop: '0px',
paddingBottom: '0px',
padding: theme.spacing(0, 2),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tcheee Tested it, seemed to work just fine for me here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants