Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme and a11y fixes #37

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Theme and a11y fixes #37

merged 2 commits into from
Oct 9, 2023

Conversation

ankur2136
Copy link
Contributor

  1. A11y fixes with minimum search tap size of 48dp
  2. Fix the sample code with correct color on text style which works on light and dark mode.
  3. Add focus requester on search field on country picker
  4. Wrap hint and innerTextField inside a box, so that cursor is not at the end of hint.
  5. Also remove unnecessary padding on the search field.

Attached screenshots for light and dark mode.

Screenshot 2023-10-06 at 3 13 03 PM

Screenshot 2023-10-06 at 3 12 34 PM

@ankur2136
Theme and a11y fixes
9707199 
1. A11y fixes with minimum search tap size of 48dp
2. Fix the sample code with correct color on text style which works on light and dark mode.
3. Add focus requester on search field on country picker
4. Wrap hint and innerTextField inside a box, so that cursor is not at the end of hint.
hbmartin
hbmartin approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@hbmartin hbmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic, thank you @ankur2136 !

app/src/main/java/com/togitech/togii/MainActivity.kt Outdated Show resolved Hide resolved
ccp/src/main/java/com/togitech/ccp/component/CountryDialog.kt Outdated Show resolved Hide resolved
ccp/src/main/java/com/togitech/ccp/component/CountryDialog.kt Outdated Show resolved Hide resolved
ccp/src/main/java/com/togitech/ccp/component/CountryDialog.kt Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@hbmartin hbmartin merged commit d285b28 into jump-sdk:master Oct 9, 2023
4 checks passed
@ankur2136 ankur2136 deleted the themeFixes branch October 9, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbmartin hbmartin hbmartin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ankur2136 @hbmartin