Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

predeclare global used in extension #211

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Conversation

palday
Copy link
Contributor

@palday palday commented Dec 28, 2023

potentially fixes #210

@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (063615b) 68.46% compared to head (b32d892) 68.46%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #211   +/-   ##
=======================================
  Coverage   68.46%   68.46%           
=======================================
  Files           2        2           
  Lines         799      799           
=======================================
  Hits          547      547           
  Misses        252      252           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericphanson
Copy link

this is the same as #206 fyi

@palday
Copy link
Contributor Author

palday commented Jan 2, 2024

Looking at the comments in #206, I saw that there were some thoughts on the impact of a non-const global. I think that issue existed even before now, but we can add a type-annotation to the global (all Julia versions which support extensions also support type annotations on globals), which will reduce some of the impact there.

src/NLopt.jl Outdated Show resolved Hide resolved
@montyvesselinov
Copy link

are you going to merge and release a new version?

src/NLopt.jl Outdated Show resolved Hide resolved
@stevengj stevengj merged commit cbd1634 into jump-dev:master Jan 10, 2024
8 checks passed
@stevengj
Copy link
Collaborator

Thanks for the reminder: JuliaRegistries/General#98576

@bclyons12
Copy link

@stevengj Just FYI, looks like the the new release version got hung up and won't be released automatically.

@stevengj
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

In Julia 1.10, NLoptMathOptInterfaceExt errors on load
6 participants