-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
predeclare global used in extension #211
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #211 +/- ##
=======================================
Coverage 68.46% 68.46%
=======================================
Files 2 2
Lines 799 799
=======================================
Hits 547 547
Misses 252 252 ☔ View full report in Codecov by Sentry. |
this is the same as #206 fyi |
Looking at the comments in #206, I saw that there were some thoughts on the impact of a non-const global. I think that issue existed even before now, but we can add a type-annotation to the global (all Julia versions which support extensions also support type annotations on globals), which will reduce some of the impact there. |
are you going to merge and release a new version? |
Thanks for the reminder: JuliaRegistries/General#98576 |
@stevengj Just FYI, looks like the the new release version got hung up and won't be released automatically. |
potentially fixes #210