Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethrow errors instead of returning FORCED_STOP #194

Merged
merged 8 commits into from
Mar 10, 2024
Merged

Conversation

odow
Copy link
Member

@odow odow commented Jan 25, 2023

Closes #156
Closes #157

@ikirill I didn't want to push new commits to your master branch, so I've cherry-picked your commits over to this branch.

@odow odow requested a review from stevengj January 25, 2023 23:18
@odow
Copy link
Member Author

odow commented Feb 9, 2023

Bump. Any thoughts on this?

Here's another case where throwing an error would be helpful: https://discourse.julialang.org/t/nlopt-forced-stop-after-one-iteration-gradient-based-optimization/94383

@Vaibhavdixit02
Copy link
Contributor

Bump, can we get this please will be a big Quality of Life improvement!

src/NLopt.jl Outdated Show resolved Hide resolved
@stevengj
Copy link
Collaborator

Thanks for working on this; it would be good to have.

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 69.07%. Comparing base (67acb7a) to head (8164ef3).

Files Patch % Lines
src/NLopt.jl 66.66% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #194      +/-   ##
==========================================
+ Coverage   68.83%   69.07%   +0.24%     
==========================================
  Files           2        2              
  Lines         799      802       +3     
==========================================
+ Hits          550      554       +4     
+ Misses        249      248       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow
Copy link
Member Author

odow commented Jan 15, 2024

How's this now?

Copy link
Contributor

@ararslan ararslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, for whatever that's worth 😄

@Vaibhavdixit02
Copy link
Contributor

I ran into this earlier today as well 😅

@odow
Copy link
Member Author

odow commented Mar 10, 2024

I'll merge once CI has passed.

@odow odow merged commit 605be7e into master Mar 10, 2024
8 checks passed
@odow odow deleted the od/forced-stop branch March 10, 2024 00:06
@odow odow mentioned this pull request Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Exception thrown by objective function is not rethrown by nlopt
7 participants