Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use StridedMaybeAdjOrTransMat instead of defining it #217

Merged
merged 1 commit into from
May 2, 2023
Merged

use StridedMaybeAdjOrTransMat instead of defining it #217

merged 1 commit into from
May 2, 2023

Conversation

dkarrasch
Copy link
Contributor

This move avoids conflicts that may occur with slightly changing the use of the type parameter in JuliaLang/julia#49521. It is necessary because in that linalg file, the Blas* restriction is usually used in the place of the eltype of the StridedArray, and not as the eltype of the Adjoint or Transpose. Moving the definition here into the VERSION branch neatly adopts that change and makes the package run smoothly across v1.6 - v1.10.

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: +2.30 🎉

Comparison is base (677e5e7) 86.73% compared to head (cb5b915) 89.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #217      +/-   ##
==========================================
+ Coverage   86.73%   89.04%   +2.30%     
==========================================
  Files          22       23       +1     
  Lines        1923     2136     +213     
==========================================
+ Hits         1668     1902     +234     
+ Misses        255      234      -21     
Impacted Files Coverage Δ
src/dispatch.jl 49.47% <ø> (+8.59%) ⬆️

... and 19 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blegat
Copy link
Member

blegat commented May 2, 2023

Thanks! It's indeed helpful for MutableArithmetics to try to reduce the number of methods in stdlib as done in JuliaLang/julia#49521

@blegat blegat merged commit 211e34e into jump-dev:master May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants