Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generic matmult in LinearAlgebra.jl #176

Merged
merged 6 commits into from
Nov 21, 2022
Merged

Fix generic matmult in LinearAlgebra.jl #176

merged 6 commits into from
Nov 21, 2022

Conversation

odow
Copy link
Member

@odow odow commented Nov 17, 2022

Closes #175

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Base: 86.14% // Head: 86.17% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (9b7ee8d) compared to base (352aa8f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
+ Coverage   86.14%   86.17%   +0.02%     
==========================================
  Files          20       20              
  Lines        1877     1881       +4     
==========================================
+ Hits         1617     1621       +4     
  Misses        260      260              
Impacted Files Coverage Δ
src/implementations/LinearAlgebra.jl 97.31% <100.00%> (+0.07%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@odow
Copy link
Member Author

odow commented Nov 17, 2022

This whole system of LinearAlgebra with abstract types is a mess. Base fails, MA fails, and there are changes between Julia versions :(

@blegat
Copy link
Member

blegat commented Nov 21, 2022

Yes, I think this fix is the right thing to do. We don't want to look at the first elements and broaden the array type if needed etc... If the eltypes are not concrete it's ok to use a less performant approach.
This could cause issues with users suddenly getting extremely bad performance but then I think we could add an additional preprocessing here that tries to see if all elements are actually of the same type even if the eltype is not concrete.

@odow odow merged commit 5c4d464 into master Nov 21, 2022
@odow odow deleted the od/fix-generic-matmul branch November 21, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

*(::AbstractArray, ::AbstractArray) is wrong
2 participants