Implement ConstraintFunction/ConstraintSet for VariablesContainer #1635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
@odow What do you think of merging this and cutting a v0.10.4 release so that we can update JuMP to MA v0.3 ? |
odow
approved these changes
Oct 23, 2021
| @@ -208,11 +211,11 @@ function test_errors_ConstraintSet_NotAllowed() | |||
| MOI.set(model, MOI.ConstraintSet(), ci, MOI.EqualTo(1.0)) | |||
| ) | |||
| @test_throws( | |||
| ArgumentError, | |||
| MOI.SetTypeMismatch{MOI.EqualTo{Float64},MOI.EqualTo{Int}}, | |||
There was a problem hiding this comment.
Is this going to break solver tests?
There was a problem hiding this comment.
I don't expect many solver to throw the ArgumentError. They should rely on the fallback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for jump-dev/NLopt.jl#177
Since
VariablesContaineris not aModelLike, we need to reimplement the errors for setting function and sets of incorrect type. I thought we might as well defined proper error types instead of copy-pasting ArgumentError or creating helper functions.