Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing KeyIterator used for JuMPArray to work also when index sets are non indexable. #836

Merged
merged 8 commits into from
Sep 27, 2016
Merged

Fixing KeyIterator used for JuMPArray to work also when index sets are non indexable. #836

merged 8 commits into from
Sep 27, 2016

Commits on Aug 21, 2016

  1. keys() work as expected now for JuMPArray when index set is not index… 

    …able
    @IssamT
    IssamT committed Aug 21, 2016
    Configuration menu
    Copy the full SHA
    734b58e View commit details
    Browse the repository at this point in the history

  2. minor comment modification

    @IssamT
    IssamT committed Aug 21, 2016
    Configuration menu
    Copy the full SHA
    4204781 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2016

  1. fixed indentation to be 4 spaces

    @IssamT
    IssamT committed Aug 23, 2016
    Configuration menu
    Copy the full SHA
    5e59724 View commit details
    Browse the repository at this point in the history

  2. moved the initialization of KeyIterator state from constructor to Bas… 

    …e.start
    @IssamT
    IssamT committed Aug 23, 2016
    Configuration menu
    Copy the full SHA
    452743c View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2016

  1. improved KeyIterator of JuMPArrays in two ways: 

    - now the functions start next done do not modify arguments
- less allocation thanks to caching and @generated functions
    @IssamT
    IssamT committed Sep 3, 2016
    Configuration menu
    Copy the full SHA
    cc53bdc View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2016

  1. added JuMPKey, a tuple wrapper, to be used by keys(::JuMPArray)

    @IssamT
    IssamT committed Sep 8, 2016
    Configuration menu
    Copy the full SHA
    ab0d709 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2016

  1. added specialization of the iterator to keep good performance 

    when having indexable sets
    @IssamT
    IssamT committed Sep 12, 2016
    Configuration menu
    Copy the full SHA
    ee819c7 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2016

  1. - removed JuMPKey (to be added in separate PR) 

    - removed traits for indexability of indexsets
- added a test with sets indexsets of JuMPArray
    @IssamT
    IssamT committed Sep 21, 2016
    Configuration menu
    Copy the full SHA
    c980b33 View commit details
    Browse the repository at this point in the history