Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix StackOverflow error in value of GenericNonlinearExpr #3889

Merged
merged 6 commits into from
Nov 23, 2024

Conversation

odow
Copy link
Member

@odow odow commented Nov 22, 2024

Closes #3884

It wasn't as complicated as I thought.

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.58%. Comparing base (701251a) to head (47cfa8e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3889   +/-   ##
=======================================
  Coverage   99.58%   99.58%           
=======================================
  Files          43       43           
  Lines        6031     6041   +10     
=======================================
+ Hits         6006     6016   +10     
  Misses         25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@odow odow changed the title Fix StackOverflow error in value of GenericNonlinearExpr WIP: Fix StackOverflow error in value of GenericNonlinearExpr Nov 22, 2024
@odow odow changed the title WIP: Fix StackOverflow error in value of GenericNonlinearExpr Fix StackOverflow error in value of GenericNonlinearExpr Nov 23, 2024
@odow odow merged commit 1230ea6 into master Nov 23, 2024
11 checks passed
@odow odow deleted the od/value-stackoverflow branch November 23, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Stack overflow error when find the value of deeply nested nonlinear expressions
1 participant