Fix bug which mutates user expressions in constraint macro #3883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3883 +/- ##
=======================================
Coverage 99.58% 99.58%
=======================================
Files 43 43
Lines 6029 6036 +7
=======================================
+ Hits 6004 6011 +7
Misses 25 25 ☔ View full report in Codecov by Sentry. |
odow
commented
Nov 14, 2024
odow
commented
Nov 14, 2024
odow
commented
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3882
This is a temporary fix. A longer-term approach is to return the
is_mutable::Boolvalue from MutableArithemtics:https://github.com/jump-dev/MutableArithmetics.jl/blob/d47000d5e02100458aff33670684a95f105ec40a/src/rewrite.jl#L341
which would let JuMP decide whether it needed to call
copy_if_mutable.