Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test/mutable_arithmetics.jl #2284

Merged
merged 2 commits into from
Jul 17, 2020
Merged

Refactor test/mutable_arithmetics.jl #2284

merged 2 commits into from
Jul 17, 2020

Conversation

odow
Copy link
Member

@odow odow commented Jul 15, 2020

In addition, disable JuMPExtension tests. They double our testing time
without adding much in the way of extra coverage.

Extracted from #2277

…ted testsets

In addition, disable JuMPExtension tests. They double our testing time
without adding much in the way of extra coverage.
@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #2284 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2284      +/-   ##
==========================================
+ Coverage   91.25%   91.35%   +0.09%     
==========================================
  Files          42       42              
  Lines        4233     4234       +1     
==========================================
+ Hits         3863     3868       +5     
+ Misses        370      366       -4     
Impacted Files Coverage Δ
src/constraints.jl 91.11% <0.00%> (-0.75%) ⬇️
src/operators.jl 91.15% <0.00%> (+3.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fecaca...c5697b3. Read the comment docs.

@odow odow requested a review from blegat July 16, 2020 16:11
@odow
Copy link
Member Author

odow commented Jul 16, 2020

@blegat are you okay dropping the JuMPExtension tests? Saves us nearly 2 minutes of test time.

@blegat
Copy link
Member

blegat commented Jul 17, 2020

It's important to test that we use AbstractVariableRef here: https://github.com/jump-dev/JuMP.jl/blob/master/src/mutable_arithmetics.jl#L21
for instance. Maybe we could run them for promote_operation tests only.

@odow odow merged commit ec86780 into master Jul 17, 2020
@odow odow deleted the od/test_ma branch July 17, 2020 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants