Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate Gittip with Julython #43

Closed
chadwhitacre opened this issue Jan 5, 2013 · 8 comments
Closed

integrate Gittip with Julython #43

chadwhitacre opened this issue Jan 5, 2013 · 8 comments

Comments

@chadwhitacre
Copy link
Contributor

There's a couple ways this could be done:

  1. Use the Julython user's GitHub and/or Twitter account to format a Gittip URL, like https://www.gittip.com/on/github/rmyers/.
  2. Add a field to the Julython user object to collect a Gittip username.

Then I was thinking this would show up on a person page:

+Gittip

Is this something you'd be interested in?

@rmyers
Copy link
Member

rmyers commented Jan 5, 2013

Approved :)

@chadwhitacre
Copy link
Contributor Author

Thanks, @rmyers! :-D

Based on conversation over on rubygems/rubygems.org#500, I'd prefer to go with option 2 above, the explicit opt-in via an additional field on the Julython profile page.

@rmyers
Copy link
Member

rmyers commented Jan 11, 2013

Yes @whit537 I agree. We are using Django 1.5 for the custom user model so this should be fairly simple to implement.

  • add field to july.models.User
  • make a migration
  • add field to profile form/modify template

@chadwhitacre
Copy link
Contributor Author

I got Twitter auth working locally. I added a field to the model. I'm looking at migration docs here (yes?):

http://south.readthedocs.org/en/latest/migrationstructure.html

@chadwhitacre
Copy link
Contributor Author

I just did an automatic schema migration:

(env)$ ./manage.py schemamigration july --auto add_gittip_field
 + Added field gittip on july.User
Created 0002_add_gittip_field.py. You can now apply this migration with: ./manage.py migrate july
(env)$ ./manage.py migrate july
Running migrations for july:
 - Migrating forwards to 0002_add_gittip_field.
 > july:0002_add_gittip_field
 - Loading initial data for july.
Installed 0 object(s) from 0 fixture(s)
(env)$

@chadwhitacre
Copy link
Contributor Author

From july/templates/people/edit.html it looks like the form is autogenerated. Not sure yet where the form object in that template is coming from, will dig further.

Also, will want to land these before I make a pull request here:

https://github.com/zetaweb/www.gittip.com/issues/464
https://github.com/zetaweb/www.gittip.com/issues/465

@rmyers
Copy link
Member

rmyers commented Jan 13, 2013

@whit537 looks like you are on the right track. Form for this is july.people.forms.EditUserForm

rmyers pushed a commit that referenced this issue Jan 23, 2013
@rmyers rmyers closed this as completed Jan 23, 2013
@chadwhitacre
Copy link
Contributor Author

Thanks so much for picking this up, @rmyers. I really appreciate it. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants