Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues found by PVS-Studio static analyzer #7 #34

Merged
merged 18 commits into from
Nov 27, 2023
Merged

Fix issues found by PVS-Studio static analyzer #7 #34

merged 18 commits into from
Nov 27, 2023

Conversation

dimhotepus
Copy link
Contributor

@dimhotepus dimhotepus commented Nov 26, 2023 •
edited
Loading

@dimhotepus
rtp: Ensure no null derference when RtpSocket is null
85c6642
@dimhotepus
rtp: Correctly check rtp data available
5ef1205
@dimhotepus
rtp: Drop duplicated assignment to fraction
abd50bc
@dimhotepus
all: Use == in some cases for struct types
72b7980
@dimhotepus
rtp: Use short-circuit || operator to pssedup condition eval
91700a9
@dimhotepus
rtp: Do not throw if frameChannel is null
8123de1
@dimhotepus
rtp: Simplify condition for static analyzer
e8beee1
@dimhotepus
rtp: Split assignment and condition
5017a00
@dimhotepus
rtp: Use nameof for getting argument name
6f7cfa0
@dimhotepus
rtsp: string.Split results in array with length >= 0
87c59e9
@dimhotepus
rtsp: Correctly check offset range
19ef95c
@dimhotepus
rtsp: Use pattern matching for some Enum conditions
47407bd
@dimhotepus
all: Fix typo recieved -> recieved
f622994
@dimhotepus
all: Codeplex is down, use correct repo link
e7702b9
@dimhotepus
all: Use https:// license link
47cd0bb
@dimhotepus
all: http:// -> https://
c9eb19d
@dimhotepus dimhotepus changed the title PVS-Studio fixes #6 Fix issues found by PVS-Studio static analyzer #7 Nov 26, 2023
juliusfriedman
juliusfriedman reviewed Nov 27, 2023
View reviewed changes
Rtp/RtpClient.cs Outdated Show resolved Hide resolved
@juliusfriedman
Update RtpClient.cs
3b594e2 
Fixed conditions in 2 places.

Signed-off-by: Julius R Friedman <[email protected]>
@juliusfriedman
Copy link
Owner

juliusfriedman commented Nov 27, 2023 •
edited
Loading

I edited the file in the places where we should change the checks, The build is failing because I missed a using statement, but then I realized I should confirm with you if you want to use the long way of calling the extension or the shortway

e.g. socket.IsNullOrDisposed() is false OR SocketExtensions.IsNullOrDisposed(socket) is false

Please let me know or I will fix it up asap!

Thanks again for your contributions!

@juliusfriedman
Update RtpClient.cs
8273bb0 
Added using.

Signed-off-by: Julius R Friedman <[email protected]>
@juliusfriedman
Copy link
Owner

I added the using Media.Common.Extensions.Socket; and kept it the short way for now. I will merge once CI completes.

Thank you!!!

@juliusfriedman
Copy link
Owner

Changes LGTM. Thanks for your contributions!

@juliusfriedman juliusfriedman merged commit 07a9fd8 into juliusfriedman:master Nov 27, 2023
3 checks passed
@dimhotepus dimhotepus deleted the pvs-studio-fixes branch November 27, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusfriedman juliusfriedman juliusfriedman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimhotepus @juliusfriedman