updated to include '.' in RE_PARAM; mysqljs#14

julius-e · May 14, 2019 · 8363a74 · 8363a74
1 parent d5134a3
commit 8363a74
Show file tree

Hide file tree

Showing 3 changed files with 275 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -3,7 +3,7 @@
 // based on code from Brian White @mscdex mariasql library - https://github.com/mscdex/node-mariasql/blob/master/lib/Client.js#L272-L332
 // License: https://github.com/mscdex/node-mariasql/blob/master/LICENSE
 
-const RE_PARAM = /(?:\?)|(?::(\d+|(?:[a-zA-Z][a-zA-Z0-9_]*)))/g,
+const RE_PARAM = /(?:\?)|(?::(\d+|(?:[a-zA-Z][a-zA-Z0-9_\.]*)))/g,
 DQUOTE = 34,
 SQUOTE = 39,
 BSLASH = 92;

diff --git a/package-lock.json b/package-lock.json
diff --git a/test/example.js b/test/example.js
@@ -23,6 +23,11 @@ describe('given input query with named parameters', () => {
     compile(query, { id: Number(123) })
     .should.eql([ 'SELECT * FROM items WHERE deleted = "0000-00-00 00:00:00" AND id = ?',
     [ 123 ] ]);
+
+    query = 'SELECT * FROM items WHERE deleted = "0000-00-00 00:00:00" AND `dot.id` = :dot.id';
+    compile(query, { 'dot.id': Number(123) })
+    .should.eql([ 'SELECT * FROM items WHERE deleted = "0000-00-00 00:00:00" AND `dot.id` = ?',
+    [ 123 ] ]);
   });
 
   it('should throw error when query contains placeholders but parameters object not passed', () => {