Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting the maxResults on the KeyVaultConfigService causes the retrival of the secrets to fail #73

Closed
rfrappier opened this issue Sep 6, 2018 · 1 comment
Labels
bug Something isn't working

Comments

@rfrappier
Copy link

setting maxResults, see below, will later fail when trying to retrieve a config parameter

new KeyVaultConfigService({
keyVaultUrl: process.env.KEYVAULT!,
maxResults: 40,
});

@julienblin julienblin added the bug Something isn't working label Sep 7, 2018
@julienblin
Copy link
Owner

maxResults > 25 triggers an Error in the Azure KeyVaultClient class:

UnhandledPromiseRejectionWarning: Error: "maxresults" should satisfy the constraint - "InclusiveMaximum": 25
    at KeyVaultClient._getSecrets (/Users/julien/dev/uno-serverless/packages/uno-serverless-azure/node_modules/azure-keyvault/lib/keyVaultClient.js:4214:15)
    at Promise (/Users/julien/dev/uno-serverless/packages/uno-serverless-azure/node_modules/azure-keyvault/lib/keyVaultClient.js:18388:14)
    at new Promise (<anonymous>)
    at KeyVaultClient.getSecrets (/Users/julien/dev/uno-serverless/packages/uno-serverless-azure/node_modules/azure-keyvault/lib/keyVaultClient.js:18387:14)
    at KeyVaultConfigService.getParameters (/Users/julien/dev/uno-serverless/packages/uno-serverless-azure/src/services/config.ts:88:24)
    at <anonymous>
    at process._tickDomainCallback (internal/process/next_tick.js:228:7)

However, the class needs to be fixed to properly handle nextLinks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants