Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF8: Make Creative EAX Unified as an optional dependency #718

Merged

Conversation

myst6re
Copy link
Contributor

@myst6re myst6re commented Aug 22, 2024

Summary

Make Creative EAX Unified as an optional dependency

  • search the eax.dll in ./creative_eax.dll before searching in system dir

Motivation

On the 2000-version, eax.dll is replaced by FFNx, but the original eax.dll is still mandatory, as it is used to instanciate DirectSound.
On today hardware, EAX does nothing special, so it seems fair to partially remove this dependency.

ACKs

  • I have updated the Changelog.md file
  • I did test my code on FF7
  • I did test my code on FF8

@myst6re myst6re force-pushed the feature/portable-creative-eax branch from cd4a2ae to 92c5b67 Compare August 22, 2024 21:21
@myst6re myst6re marked this pull request as ready for review August 22, 2024 21:21
@julianxhokaxhiu julianxhokaxhiu added the enhancement New feature or request label Aug 23, 2024
@julianxhokaxhiu julianxhokaxhiu added this to the 1.20.0 milestone Aug 23, 2024
@julianxhokaxhiu julianxhokaxhiu merged commit 1ab9391 into julianxhokaxhiu:master Aug 23, 2024
@julianxhokaxhiu
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants