-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FF8: Gamepad input/rendering fixes #647
Merged
julianxhokaxhiu
merged 2 commits into
julianxhokaxhiu:master
from
myst6re:fix/ff8-fix-analog-directions-joystick
Jan 28, 2024
Merged
FF8: Gamepad input/rendering fixes #647
julianxhokaxhiu
merged 2 commits into
julianxhokaxhiu:master
from
myst6re:fix/ff8-fix-analog-directions-joystick
Jan 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myst6re
force-pushed
the
fix/ff8-fix-analog-directions-joystick
branch
2 times, most recently
from
January 23, 2024 11:58
4e1b31e
to
62d20eb
Compare
julianxhokaxhiu
previously approved these changes
Jan 23, 2024
julianxhokaxhiu
dismissed
their stale review
January 23, 2024 17:40
The merge-base changed after approval.
julianxhokaxhiu
force-pushed
the
master
branch
11 times, most recently
from
January 27, 2024 09:52
ad7e19e
to
0787003
Compare
myst6re
force-pushed
the
fix/ff8-fix-analog-directions-joystick
branch
from
January 27, 2024 16:26
6e43e68
to
fd80358
Compare
myst6re
changed the title
FF8: fix analog direction for DirectInput (legacy) controllers
FF8: fix analog direction for DirectInput (legacy) controllers + fix ps1 icon mapping in field
Jan 27, 2024
myst6re
changed the title
FF8: fix analog direction for DirectInput (legacy) controllers + fix ps1 icon mapping in field
FF8: fix analog direction for DirectInput controllers + fix ps1 icon mapping in field
Jan 27, 2024
julianxhokaxhiu
force-pushed
the
master
branch
9 times, most recently
from
January 27, 2024 21:03
6efeb52
to
5e70574
Compare
julianxhokaxhiu
force-pushed
the
master
branch
11 times, most recently
from
January 27, 2024 23:10
6342d25
to
fedf0b5
Compare
Can you please rebase? Thank you :) |
myst6re
force-pushed
the
fix/ff8-fix-analog-directions-joystick
branch
from
January 28, 2024 13:17
fd80358
to
a39b2d5
Compare
Done |
There's a build issue for some reason, can you please have a look? |
myst6re
force-pushed
the
fix/ff8-fix-analog-directions-joystick
branch
from
January 28, 2024 15:29
a39b2d5
to
5c6fad4
Compare
Bad merge sorry, it builds |
julianxhokaxhiu
approved these changes
Jan 28, 2024
julianxhokaxhiu
changed the title
FF8: fix analog direction for DirectInput controllers + fix ps1 icon mapping in field
FF8: Gamepad input/rendering fixes
Jan 28, 2024
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix analog direction for DirectInput (legacy) controllers
ACKs