Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF8: Gamepad input/rendering fixes #647

Conversation

myst6re
Copy link
Contributor

@myst6re myst6re commented Jan 23, 2024

Summary

Fix analog direction for DirectInput (legacy) controllers

ACKs

  • I have updated the Changelog.md file
  • I did test my code on FF7
  • I did test my code on FF8

@myst6re myst6re force-pushed the fix/ff8-fix-analog-directions-joystick branch 2 times, most recently from 4e1b31e to 62d20eb Compare January 23, 2024 11:58
@julianxhokaxhiu julianxhokaxhiu added the bug Something isn't working label Jan 23, 2024
@julianxhokaxhiu julianxhokaxhiu added this to the 1.18.0 milestone Jan 23, 2024
@julianxhokaxhiu julianxhokaxhiu dismissed their stale review January 23, 2024 17:40

The merge-base changed after approval.

@myst6re myst6re force-pushed the fix/ff8-fix-analog-directions-joystick branch from 6e43e68 to fd80358 Compare January 27, 2024 16:26
@myst6re myst6re changed the title FF8: fix analog direction for DirectInput (legacy) controllers FF8: fix analog direction for DirectInput (legacy) controllers + fix ps1 icon mapping in field Jan 27, 2024
@myst6re myst6re changed the title FF8: fix analog direction for DirectInput (legacy) controllers + fix ps1 icon mapping in field FF8: fix analog direction for DirectInput controllers + fix ps1 icon mapping in field Jan 27, 2024
@julianxhokaxhiu
Copy link
Owner

Can you please rebase? Thank you :)

@myst6re myst6re force-pushed the fix/ff8-fix-analog-directions-joystick branch from fd80358 to a39b2d5 Compare January 28, 2024 13:17
@myst6re
Copy link
Contributor Author

myst6re commented Jan 28, 2024

Can you please rebase? Thank you :)

Done

@julianxhokaxhiu
Copy link
Owner

There's a build issue for some reason, can you please have a look?

@myst6re myst6re force-pushed the fix/ff8-fix-analog-directions-joystick branch from a39b2d5 to 5c6fad4 Compare January 28, 2024 15:29
@myst6re
Copy link
Contributor Author

myst6re commented Jan 28, 2024

There's a build issue for some reason, can you please have a look?

Bad merge sorry, it builds

@julianxhokaxhiu julianxhokaxhiu changed the title FF8: fix analog direction for DirectInput controllers + fix ps1 icon mapping in field FF8: Gamepad input/rendering fixes Jan 28, 2024
@julianxhokaxhiu julianxhokaxhiu merged commit d9dab67 into julianxhokaxhiu:master Jan 28, 2024
@julianxhokaxhiu
Copy link
Owner

Thank you!

@myst6re myst6re deleted the fix/ff8-fix-analog-directions-joystick branch January 28, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants