Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF7: Fix a softlock when trying to change in-game Controller setting to "Normal" #626

Merged

Conversation

maciej-trebacz
Copy link
Contributor

Summary

Fixes issue #623 by disabling the ability to change the Controller setting to "Normal". This is what Aali driver originally did and this change apparently wasn't ported to FFNx.

ACKs

  • I have updated the Changelog.md file
  • I did test my code on FF7
  • I did test my code on FF8

Copy link
Owner

@julianxhokaxhiu julianxhokaxhiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR as well. Also here I left a comment on the specific part which would also impact 1998 edition.

src/ff7_opengl.cpp Outdated Show resolved Hide resolved
Copy link
Owner

@julianxhokaxhiu julianxhokaxhiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last change sorry, spotted it now. Thanks!

Changelog.md Outdated Show resolved Hide resolved
Changelog.md Outdated Show resolved Hide resolved
@julianxhokaxhiu julianxhokaxhiu merged commit a304000 into julianxhokaxhiu:master Nov 21, 2023
1 check passed
@julianxhokaxhiu
Copy link
Owner

Thank you :)

@maciej-trebacz maciej-trebacz deleted the fix/config_controls branch November 21, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ FF7 ] Softlock when selecting "Normal" in the Controller option in game' Config menu
2 participants