Linux fix: Search with schemas fails in cold keyrings #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the keyring is cold (e.g. after restart without a login or after running `gnome-keyring-daemon --replace` on the command line), lookup using schemas would return null entries without prompting the user for their passwords. This is especially dangerrous in situations where the user wants to write an entry to the keyring. In such case, if there were previously stored secrets in the FlutterSecretStorage entry, those would be ignored and only the new entry would be stored. Effectively erasing all previously stored passwords. The issue is explained here: https://gitlab.gnome.org/GNOME/gnome-keyring/-/issues/89 However, the solution used in this commit is the one used in the chromium browser: http://crbug.com/660005
|
Fixes #618 |
|
Thank you for your contribution! |
juliansteenbakker
merged commit a9a7100
into
juliansteenbakker:develop
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the keyring is cold (e.g. after restart without a login or after running
gnome-keyring-daemon --replaceon the command line), lookup using schemas would return null entries without prompting the user for their passwords.This is especially dangerrous in situations where the user wants to write an entry to the keyring. In such case, if there were previously stored secrets in the FlutterSecretStorage entry, those would be ignored and only the new entry would be stored. Effectively erasing all previously stored secrets.
The issue is explained here:
https://gitlab.gnome.org/GNOME/gnome-keyring/-/issues/89
However, the solution used in this commit is the one used in the chromium browser: http://crbug.com/660005