Add "window" to access to the 'navigator' property #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't kow the reason why but in my case I'm getting an error "navigator is not defined". Adding "window" in front of it, resolves my problem. As adding or not "window" should not affect the code, I assume that putting it should not be an issue for anyone but it will be appreciated by me ;)
|
Which browser was this in? |
|
I got this error when runnig tests with jest and Jasmine. |
|
Ah - looks like an issue with Jest - not a big one and don't think there's any problem there. If you can use a cache for |
Rycochet
pushed a commit
that referenced
this pull request
Aug 3, 2020
* Add "window" to access to the 'navigator' property I don't kow the reason why but in my case I'm getting an error "navigator is not defined". Adding "window" in front of it, resolves my problem. As adding or not "window" should not affect the code, I assume that putting it should not be an issue for anyone but it will be appreciated by me ;) * update min and ui.min files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't kow the reason why but in my case I'm getting an error "navigator is not defined".
Adding "window" in front of it, resolves my problem.
As adding or not "window" should not affect the code, I assume that putting it should not be an issue for anyone but it will be appreciated by me ;)