Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow import of velocity.ui in Webpack 2. #768

Closed

Conversation

abercrave
Copy link

@abercrave abercrave commented Apr 1, 2017

In response to issue #743.

This works for my purposes, but I do not know how rule out the possibility it may cause issues in other implementations.

@abercrave abercrave changed the title Allow imports of velocity.ui in Webpack 2. Allow import of velocity.ui in Webpack 2. Apr 1, 2017
@CGTS
Copy link

CGTS commented Sep 1, 2017

Thanks for this solution. This worked for me. Is this going to be merged in?

@Rycochet
Copy link
Collaborator

Rycochet commented Sep 2, 2017

As a breaking change it can only be added as part of Velocity v2 - which will be several months yet (I don't get much time unfortunately).

@Rycochet Rycochet closed this in 8fdea04 Mar 4, 2018
@abercrave abercrave deleted the velocity-ui-import-webpack branch March 7, 2018 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants