Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performance.now() polyfill #763

Merged
merged 1 commit into from
Mar 17, 2017
Merged

Fix performance.now() polyfill #763

merged 1 commit into from
Mar 17, 2017

Conversation

nicjansma
Copy link
Contributor

This fixes the performance.now() polyfill:

  • In browsers that support performance.now(), it won't be overwritten
  • In browsers that don't support performance.now() but do support NavigationTiming, it will use navigationStart as the time-origin instead of domComplete

For a more detailed explanation, please see #762

@Rycochet
Copy link
Collaborator

For future reference - looks like performance.now is prototype based and not on the object directly, hence the test failing.

@Rycochet Rycochet merged commit 8d03682 into julianshapiro:master Mar 17, 2017
Rycochet pushed a commit that referenced this pull request Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants