Improves jQuery-wrapped elements check in isWrapped. #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking for the existence of 'jquery' on an object is not as reliable as looking at the constructor's prototype of the object. Doing that affords us the opportunity to use 'jquery' for other means—and not to determine that it's a jQuery-wrapped object. Of course, this merely moves the problem up the chain. Regardless, it's a little more cemented and will work for an even larger majority of cases.
|
This one is likely to change a different way - thinking more along the lines of "check if it's array-like, and check if it's members are Elements" - that way we're not looking for specific libraries, and it can also work directly on things like |
Rycochet
added a commit
that referenced
this pull request
Aug 3, 2020
…(not specific checking for jQuery / Zepto wrapped) Closes #714
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking for the existence of 'jquery' on an object is not as reliable
as looking at the constructor's prototype of the object. Doing that
affords us the opportunity to use 'jquery' for other means—and not to
determine that it's a jQuery-wrapped object. Of course, this merely
moves the problem up the chain. Regardless, it's a little more cemented
and will work for an even larger majority of cases.