Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential fix for: Uncaught TypeError: Cannot read property 'tweensCo… #690

Merged

Conversation

304NotModified
Copy link
Contributor

…ntainer' of undefined

Fixes #305

@304NotModified
Copy link
Contributor Author

Dunno how to handle the minified

@brollb
Copy link

brollb commented Jul 28, 2016

I think you missed a check that data was not undefined - just tried this fix and got the following error:

velocity.js:2830 Uncaught TypeError: Cannot read property 'isSVG' of undefined

adding a check (data && ...) fixed it

@Rycochet
Copy link
Collaborator

@brollb You can add line comments on the code itself - but looks like one the original code was missing too, nice catch :-)

@Rycochet Rycochet merged commit 95fa142 into julianshapiro:master Aug 13, 2016
@304NotModified 304NotModified deleted the fix-tweensContainer-of-undefined branch January 27, 2017 14:07
Rycochet added a commit that referenced this pull request Aug 3, 2020
…defined

Potential fix for: Uncaught TypeError: Cannot read property 'tweensCo…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants