Fix animateParentHeight height calc when border-box #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
animateParentHeight was over-calculating the height of the children elements which have the box-sizing set to box border. This resulted in the parent being animated too tall: http://jsbin.com/xakipigino/1/edit For elements with box-sizing: "border-box", the height value returned by Velocity.CSS.getPropertyValue(element, 'height') already includes padding and border. So in these cases, padding and border should no be added when calculating the total height occupied the element.
franciscolourenco
changed the title
|
Just as a pure performance issue - but given all the possible values for border-box, you could just compare the first character with the letter "b" instead. Not quite as readable, but gives the same result ;-) |
|
Will check this out this weekend |
|
Any update available on this issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You usually don't merge pull requests, but this was reported some time ago,
and I needed a quick fix for myself, so why not upload it. Even though
animateParentHeight is probably going to be overhauled.
animateParentHeight was over-calculating the height of the children elements
which have the box-sizing set to box border. This resulted in the parent
being animated too tall: http://jsbin.com/xakipigino/1/edit
For elements with box-sizing: "border-box", the height value returned by
Velocity.CSS.getPropertyValue(element, 'height') already includes
padding and border. So in these cases, padding and border should no be
added when calculating the total height occupied the element:
http://jsbin.com/wiyejuxequ/1/edit