Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix durations set to 0 being ignored with Velocity UI #483

Merged
merged 1 commit into from
Aug 13, 2016

Conversation

jackwakefield
Copy link
Contributor

This fixes the following where the duration would be set to the effects default.

$element.velocity('transition.swoopIn', { duration: 0 });

@Rycochet
Copy link
Collaborator

Just a general observation - but you should be using if (var !== undefined) rather than using typeof - while there are (mostly irrelevant) arguments about it's use, it's the standard, and used in Velocity source already - so you should try to be consistent when contributing to an OS project :-)

@Rycochet Rycochet merged commit 5d52ae7 into julianshapiro:master Aug 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants