Allow any version of jquery, don't need to specify github repo #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cool, thanks. will merge this soon. (fyi i'm leaving in jquery since most people, including myself, still use it with jquery) |
|
Thanks @julianshapiro! Makes sense to keep the jQuery dependency in there, since it might suddenly break people's apps if we remove it. |
julianshapiro
added a commit
that referenced
this pull request
Jan 4, 2015
Allow any version of jquery, don't need to specify github repo
Rycochet
pushed a commit
that referenced
this pull request
Aug 3, 2020
Allow any version of jquery, don't need to specify github repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
bower.jsonfile currently usesjquery/jqueryin the version specifier for the jquery dependency. This isn't necessary (and is confusing), since the package name in bower is simplyjquery. This PR changes to using a standard wildcard version specifier.Alternatively, we may wish to remove this dependency altogether, since velocity no longer has a hard dependency on jquery.