Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AMD support. Tested with both builds, optimised and unoptimised. #264

Merged
merged 3 commits into from
Aug 28, 2014
Merged

Conversation

LukeChannings
Copy link

Fix for #238.

pajtai pushed a commit to grasshopper-cms/grasshopper-admin that referenced this pull request Aug 26, 2014
…ub repo. Should update bower.json when the following tickets show progress: julianshapiro/velocity#264 julianshapiro/velocity#238
@ydaniv
Copy link
Contributor

ydaniv commented Aug 27, 2014

@julianshapiro actually, looking just at the AMD wrapper fix, it looks much safer then the current one, having just one factory() inside the AMD clause, and moving the jQuery check to the body

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants