Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom user sequences #22

Merged
merged 1 commit into from
May 1, 2014

Conversation

jeffmicklos
Copy link
Contributor

PR for changes as that were brought up in Issue #20 (#20).

In summation, this change set adds support for user-defined animation sequences. This has proved to be a huge win, as I am porting all of our animation calls to velocity. We reuse a lot of specific animations and having short-hand access to them is, to put it lightly, life changing. An example of a custom defined sequence would be:

$.velocity.Sequencee.fadeOut = function(options) {
    var opts = { display: "none" };

    var propertiesMap = {
        opacity: 0
    };

    jQuery(this).velocity(propertiesMap, $.extend(options, opts));
};

Now I can just do $('div').velocity('fadeIn'). Awesome. What's even better is we can all imagine a world in which sequences do crazy awesome things beyond just fading in elements.

julianshapiro added a commit that referenced this pull request May 1, 2014
Support for custom user sequences. Thanks to @jeffmicklos and @nmussy.
@julianshapiro julianshapiro merged commit 0dc22d6 into julianshapiro:master May 1, 2014
@jeffmicklos
Copy link
Contributor Author

Thanks for the super fast action on it. everlane.com should be fully velocity'd by the end of the week!

@julianshapiro
Copy link
Owner

This is the final comment I will make in this thread:

I've finished documenting Sequences: http://julian.com/research/velocity/#sequences. Thanks again to @jeffmicklos for submitting this genius idea.

@jeffmicklos
Copy link
Contributor Author

Loved how fast we iterated on this and got it out the door, super excited to see the feature land! If you ever find yourself looking for a job, you know where to find me. :)

@julianshapiro
Copy link
Owner

<3

Rycochet pushed a commit that referenced this pull request Aug 3, 2020
Support for custom user sequences. Thanks to @jeffmicklos and @nmussy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants