-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support display: "" #184
Support display: "" #184
Conversation
That was the original behavior, until I realized that devs most often don't want the cascading styles to take effect, which is -- unless I'm missing something -- precisely why they are setting If you'd like to work around this, pass in What do you think? |
The reason I'm setting display from velocity is that I otherwise see a flash of pre-animated content on some platforms. But I wasn't using the I still think it would be nice if there was a way to pass an empty value for |
+1 For this PR. I too am working on a general purpose meteor js animation package that would benefit from this option. I would actually prefer this to be the default. I don't really understand the benefit of forcing the |
Done. Coming up in the next build. |
Please test, confirm it works, and get back to me. Thank you so much! |
Thanks, it's working for me. |
Dropped support for the easeBack and easeElastic easings. They are rarely used, look stupid, and take up a bunch of lines. Sped up bezier curve easing performance. Thanks, @gre. The display option now gets browser-prefixed if necessary. This inherently adds cross-browser support for the ‘flex’ value. Closes #257. Fixed bug where slideDown/up left excess inline styles on elements. Closes #260. cc @kpeatt, @scalvert. Allow passing an empty string to `display` to remove the inline style from the element. Closes #184. Shimmed version of jQuery’s $.dequeue() now accepts a raw DOM element *set* instead of just a single element. You can now stop custom queues individually. Closes #262.
This is a proposal to change the meaning of
display: auto
so that it leaves the final value up to the stylesheets, stripping the inlinedisplay
property off entirely.Much of the time, this gives the same effect as the previous
getDisplayType
logic, since elements will simply revert to their natural default display type. But now the user has fine-grained control over whichdisplay
value is ultimately used.Alternatively, if people really like the current meaning of
display: auto
, I could also see this new semantic being given a different name, likedisplay: blank
ordisplay: cascade
.