-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request: Include UI Pack file in package.json (for npm) #97
Comments
I don't use npm, so I'm not familiar with the workflow, but: I wanted to avoid forcing people to have to delete velocity.ui.js if they weren't using it. I was prioritizing an "opt-in" experience instead of bloating people's folders with extra files. (Having said this, I think you're right -- I should include more files by default.) Given your experience with npm, could you elucidate a bit on the workflow from a front-end development perspective. |
You could publish velocity.ui.js as it's own module, and many in the community would advocate for that (small module philosophy). But since you already have the file in this repo, I would just publish it as part of the same module. Disk space is cheap. Anyone using a sane bundler (like browserify, for example) won't get the extra file included in their final JS file unless they explicitly So, those who want the ui file would simply need to do: require('velocity-animate/velocity.ui') |
How did you ignore the file in the first place? I don't see an |
Got it. I'll update the file in an hour or so. Thanks, Feross.
In the package.json, I whitelisted files using |
Thanks! |
Anyone know of a similar workaround as above, but for jspm? |
with just npm how would I use velocity-ui-pack? |
@RandallGit I suggest opening a new issue instead of posting in one that's almost two years old. |
I want to use
velocity.ui.js
but it's not published to npm.npm install velocity-animate
Not sure why it didn't get published -- can you look into this?
The text was updated successfully, but these errors were encountered: