Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Sequences.Register() to parallel the UI Pack #94

Closed
frekw opened this issue Jun 3, 2014 · 5 comments
Closed

Create a Sequences.Register() to parallel the UI Pack #94

frekw opened this issue Jun 3, 2014 · 5 comments

Comments

@frekw
Copy link

frekw commented Jun 3, 2014

Hi!

I'm looking to add some custom effects for my web application, and like the clean syntax used to declare effects in velocity.ui.js. However, the way its currently built forces me to either modify the library itself (which I don't want) or duplicate the code used to register the effects @ https://github.com/julianshapiro/velocity/blob/master/velocity.ui.js#L487-L527 which also seems unnecessary.

Would it make sense to refactor https://github.com/julianshapiro/velocity/blob/master/velocity.ui.js#L488-L526 to Velocity.Sequences.register(name, properties) to have an official API supporting this syntax?

@julianshapiro
Copy link
Owner

Agreed. The problem is figuring out the ideal syntax; I want to make sure that the syntax I use for call creation in the UI Pack is actually universally applicable.

I'll think on this in the coming days. Thank you so much, Fredrik!

@julianshapiro julianshapiro changed the title Refactor velocity.ui so that new effects can easily be added using the same syntax Enhancement: Create a Sequences.Register function to parallel the UI Pack Jun 3, 2014
@julianshapiro julianshapiro changed the title Enhancement: Create a Sequences.Register function to parallel the UI Pack Enhancement: Create a Sequences.Register() to parallel the UI Pack Jun 3, 2014
@Merg1255
Copy link

Should be the next big addition ;)

@julianshapiro julianshapiro changed the title Enhancement: Create a Sequences.Register() to parallel the UI Pack Create a Sequences.Register() to parallel the UI Pack Jun 26, 2014
@julianshapiro julianshapiro added this to the 1.0.0 milestone Jun 27, 2014
@julianshapiro
Copy link
Owner

This issue is now part of issue #136.

julianshapiro added a commit that referenced this issue Jul 3, 2014
Transition “out” effects don’t reset opacity to 1. This is the only
default behavior change that has been made to the UI pack. Shouldn’t
affect the vast majority of use cases.

Performance improvements due to automatically forcefeeding all reset
values.

Fix reset timing bug in which reset occurs after user’s complete
callback fires. Closes #132. Closes #129.

Turned sequence registration into externally-accessible function.
Closes #94. Closes #136. Added options customizability to calls.

See http://VelocityJS.org/#uiPack.
@julianshapiro
Copy link
Owner

This took a while, @frekw, but now it's here. Check it out (see Custom Effects): http://velocityjs.org/#uiPack.

@frekw
Copy link
Author

frekw commented Jul 3, 2014

Cool! Thanks so much @julianshapiro

Rycochet pushed a commit that referenced this issue Aug 3, 2020
Transition “out” effects don’t reset opacity to 1. This is the only
default behavior change that has been made to the UI pack. Shouldn’t
affect the vast majority of use cases.

Performance improvements due to automatically forcefeeding all reset
values.

Fix reset timing bug in which reset occurs after user’s complete
callback fires. Closes #132. Closes #129.

Turned sequence registration into externally-accessible function.
Closes #94. Closes #136. Added options customizability to calls.

See http://VelocityJS.org/#uiPack.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants