Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Velocity animating children of form, instead of form itself #723

Closed
attenzione opened this issue Nov 23, 2016 · 4 comments
Closed

Velocity animating children of form, instead of form itself #723

attenzione opened this issue Nov 23, 2016 · 4 comments

Comments

@attenzione
Copy link

attenzione commented Nov 23, 2016

We have encountered strange things with 1.3.2, velocity animating children of

element, however it's applied to form element

example is here: https://jsfiddle.net/m3sw4r63/

@attenzione attenzione changed the title Velocity animating children on form, instead of form Animating children on form, instead of form Nov 23, 2016
@attenzione attenzione changed the title Animating children on form, instead of form Velocity animating children on form, instead of form Nov 23, 2016
@attenzione attenzione changed the title Velocity animating children on form, instead of form Velocity animating children of form, instead of form itself Nov 24, 2016
@attenzione
Copy link
Author

i've investigated the code and the problem is in Type.isWrapped which return true for form elements, because form have length property #L565

I think solution is to add !Type.isNode(variable) to second part of condition or change order of if statement here #L530

@Rycochet
Copy link
Collaborator

Doh, nice catch - changed the isWrapped() method as that should always return correctly wherever it's used - also fixed it so you can pass the result from document.querySelector() or document.getElementsByTagName() etc :-)

@glasser
Copy link

glasser commented Dec 16, 2016

We ran into this one today. Do you think you can release a 1.4.1 that fixes this?

@Rycochet
Copy link
Collaborator

I need to know that the issue tacked onto the end of #697 has also been fixed - then can release an update for both of them - hopefully by the end of the weekend either way.

Rycochet added a commit that referenced this issue Aug 3, 2020
…has a length and is not wrapped, so disallow Nodes Fixes #723
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants