Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: fadeOut doesn't run in form element edge case #72

Closed
theseyi opened this issue May 18, 2014 · 5 comments
Closed

Bug: fadeOut doesn't run in form element edge case #72

theseyi opened this issue May 18, 2014 · 5 comments
Labels

Comments

@theseyi
Copy link

theseyi commented May 18, 2014

Hey @julianshapiro amazing work and thank you for all the hard work you're putting in.

It's possible I'm doing something wrong but I'm running of the latest repo (f445d1b) and velocity('fadeOut') fails, while 'fadeIn' works as expected. Replacing the same statement with the jQuery implementation works as expected: $(element).fadeOut().
This is the snippet:
$('[name="sign-in"]', '#sign-in')
.velocity('fadeOut', {queue: false});
ps: queueing does not resolve it either.
Thanks.

@julianshapiro julianshapiro changed the title velocity('fadeOut') fails to run. Question: velocity('fadeOut') fails to run May 18, 2014
@julianshapiro
Copy link
Owner

@theseyi,

I can confirm that there is a bug.

It has been fixed. (For the record, this was the strangest bug fix I've ever made; it was a super rare edge case, and the problem lay with the DOM and not Velocity.)

When I wake up tomorrow, I will do additional testing then push the new release to GitHub.

Thank you so much, Seyi! :) I very much appreciate your help and time. Stay tuned for tomorrow.

@julianshapiro julianshapiro changed the title Question: velocity('fadeOut') fails to run Bug: fadeOut doesn't run in form element edge case May 19, 2014
@theseyi
Copy link
Author

theseyi commented May 19, 2014

@julianshapiro 👍 glad to help, your work is awesome so the pleasure is all mine. I'll be on the look out tomorrow, hopefully you get some rest today since it's Her Majesty's birthday.

Cheers,

btw I'm recommending to my boss that we switch to velocity at work, should be pretty easy to convince mgmt :)

@julianshapiro
Copy link
Owner

Thank you for the kind words, my friend!

Beautiful! Would love to see what you guys make with it.

If you find any additional bugs in the future, I'll be sure to fix them ASAP.

@julianshapiro
Copy link
Owner

Could you please confirm your issue is solved with the latest version of Velocity?

@theseyi
Copy link
Author

theseyi commented May 19, 2014

Solved. Cheers 👍

Rycochet pushed a commit that referenced this issue Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants