-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: fadeOut doesn't run in form element edge case #72
Comments
I can confirm that there is a bug. It has been fixed. (For the record, this was the strangest bug fix I've ever made; it was a super rare edge case, and the problem lay with the DOM and not Velocity.) When I wake up tomorrow, I will do additional testing then push the new release to GitHub. Thank you so much, Seyi! :) I very much appreciate your help and time. Stay tuned for tomorrow. |
@julianshapiro 👍 glad to help, your work is awesome so the pleasure is all mine. I'll be on the look out tomorrow, hopefully you get some rest today since it's Her Majesty's birthday. Cheers, btw I'm recommending to my boss that we switch to velocity at work, should be pretty easy to convince mgmt :) |
Thank you for the kind words, my friend! Beautiful! Would love to see what you guys make with it. If you find any additional bugs in the future, I'll be sure to fix them ASAP. |
Could you please confirm your issue is solved with the latest version of Velocity? |
Solved. Cheers 👍 |
Hey @julianshapiro amazing work and thank you for all the hard work you're putting in.
It's possible I'm doing something wrong but I'm running of the latest repo (f445d1b) and velocity('fadeOut') fails, while 'fadeIn' works as expected. Replacing the same statement with the jQuery implementation works as expected: $(element).fadeOut().
This is the snippet:
$('[name="sign-in"]', '#sign-in')
.velocity('fadeOut', {queue: false});
ps: queueing does not resolve it either.
Thanks.
The text was updated successfully, but these errors were encountered: