Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display: 'flex' doesn't provide all prefixing needed #273

Closed
kpeatt opened this issue Aug 27, 2014 · 3 comments
Closed

Display: 'flex' doesn't provide all prefixing needed #273

kpeatt opened this issue Aug 27, 2014 · 3 comments

Comments

@kpeatt
Copy link

kpeatt commented Aug 27, 2014

Just noticed you don't like PRs. Flexbox is one of those weird ones where the syntax changed mid-specification. The current implementation of the flexbox prefixer in Velocity only creates the following prefixes:

.class {
    display: -ms-flex;         /* This isn't the right setting for IE */
    display: -webkit-flex;     /* NEW - iOS7+ */
    display: flex;             /* Chrome */
}

I would expect that it provide all supported values:

.class {
    display: -webkit-box;      /* OLD - iOS 6-, Safari 3.1-6 */
    display: -moz-box;         /* OLD - Firefox 19  */
    display: -ms-flexbox;      /* TWEENER - IE 10 */
    display: -webkit-flex;     /* NEW - iOS7+ */
    display: flex;             /* Chrome */
}

Ideally, providing display: 'flex' should generate all of these values for full browser support.

@julianshapiro
Copy link
Owner

Will do. Coming up tomorrow.

@kpeatt
Copy link
Author

kpeatt commented Aug 28, 2014

Rad, thanks man.

@julianshapiro
Copy link
Owner

Done. Please update to the latest version of Velocity and get back to me.

Rycochet pushed a commit that referenced this issue Aug 3, 2020
Add broader browser support for `display: flex`. Closes #273.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants