Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$.Velocity.animate doesn't accept a single element when using a Sequence. #247

Closed
jods4 opened this issue Aug 16, 2014 · 1 comment
Closed
Labels

Comments

@jods4
Copy link

jods4 commented Aug 16, 2014

Assuming element is a native DOM element, this works:
$.Velocity.animate(element, { top: 200 })
but this doesn't:
$.Velocity.animate(element, "transition.bounceIn")

From a quick glance at the code, it seems that animate wants an array or a jQuery object when using a Sequence. It would be handy if one could directly pass a single DOM element.

@julianshapiro
Copy link
Owner

Fixed. Expect it in the next release. For now, change line 1799 to:

$.each(Type.isNode(elements) ? [ elements ] : elements, function(elementIndex, element) {

Thank you very much, @jods4. Please confirm all works as expected.

Rycochet pushed a commit that referenced this issue Aug 3, 2020
Fixes sequences with raw DOM elements and utility function. Closes
#247. Closes #249. Thanks, @fattenap.

Prepare Velocity for the upcoming jQuery shim. Closes #208.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants