Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in SVG animation #199

Closed
lshrinivas opened this issue Jul 22, 2014 · 4 comments
Closed

Bug in SVG animation #199

lshrinivas opened this issue Jul 22, 2014 · 4 comments
Labels
Bug

Comments

@lshrinivas
Copy link

The y2 property on an SVG line element doesn't animate correctly. The other properties work correctly - this is due to a typo here: https://github.com/julianshapiro/velocity/blob/master/jquery.velocity.js#L1056

The offending line:

var SVGAttributes = "width|height|x|y|cx|cy|r|rx|ry|x1|x2|y1|y1";

should be:

var SVGAttributes = "width|height|x|y|cx|cy|r|rx|ry|x1|x2|y1|y2";

(Note the y1 -> y2 at the end)
@julianshapiro
Copy link
Owner

Thanks! You're awesome. This will be fixed in this week's release. Stay tuned.

@lshrinivas
Copy link
Author

Thanks for the prompt response! I just started using Velocity for animating SVGs, and it's amazing how much faster it is than Snap.

@julianshapiro
Copy link
Owner

Maybe I should put that quote on the website :)

@julianshapiro
Copy link
Owner

Fixed. Please update Velocity and let me know if this issue persists.

Rycochet pushed a commit that referenced this issue Aug 3, 2020
@julianshapiro @Rycochet
Upgrades
dd66174 
Switch “animating” indicator class to “velocity-animating”. Closes #194.

Support for passing hex values into color properties. (Previously, you
could only pass in individual RGBA components.) Closes #179.

Fixes bug where slide functions wouldn’t reset elements’ height to
auto. Closes #183.

Support for getting border-color in Firefox. Closes #196.

Fixes inability to animate `y2` on SVG elements. Closes #199.

Allow passing in explicit `display: none` into an Out UI pack
transition. Closes #201.

Fixes vw/vh unit support for `translateX/Y`. Closes #181.

Fixes bug where `delay` couldn’t be used with `stagger`. Closes #202.
Thank you, @Guanche.

Fixes bug where original call’s easing type wouldn’t be re-used for a
`reverse` command.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@julianshapiro @lshrinivas