Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IE8 unwanted console.log #134

Closed
Hiswe opened this issue Jun 30, 2014 · 6 comments · Fixed by #139
Closed

IE8 unwanted console.log #134

Hiswe opened this issue Jun 30, 2014 · 6 comments · Fixed by #139

Comments

@Hiswe
Copy link
Contributor

Hiswe commented Jun 30, 2014

Hi,

I encounter some problems while using velocity with IE8.
It shows some logs when doing “illegal” stuff and that leads to breaking front code when the console is not opened (IE8 magic).

the involved line is 1260

If the purpose is really to break, you should make a throw.
If not, it should be wrapped with either your Velocity.debug or at least testing the console object if (window.console != null)

I can do a pull request with the solution you prefer if you want :)
@julianshapiro
Copy link
Owner

You're right. It should be wrapped in Velocity.debug. I'll be pushing a change tonight. If you want to contribute, wait until I push to PR and add the .debug check.

@Hiswe
Copy link
Contributor Author

Hiswe commented Jun 30, 2014

Ok thanks!
I will do this tomorrow with if (Velocity.debug).

@julianshapiro
Copy link
Owner

Ok. Go ahead.

@julianshapiro
Copy link
Owner

FYI If you don't do this sometime in the next 12 hours, I will do it myself ^_^

<3

@Hiswe
Copy link
Contributor Author

Hiswe commented Jul 1, 2014

:) It's been a hard night to watch football until 6 in the mornin'.
I'll do it in less than 12 hours!

@Hiswe Hiswe mentioned this issue Jul 1, 2014
Merged
@Hiswe
Copy link
Contributor Author

Hiswe commented Jul 1, 2014

I messed up the first branch: so used to auto white-space trimming…
You should find the pull request on the ie8-console branch, the one that has been pull-requested (¬ ¬)'

BTW I haven't understand why the Gruntfile is ignored by git ? How can we run jsHint ?

julianshapiro added a commit that referenced this issue Jul 1, 2014
@julianshapiro
3D SVG Support
7d74382 
Added support for 3D CSS transforms for SVG elements (for all browsers
but IE and Android non-Chrome, where it’s not possible). Closes #137.
(Thanks, @jackrugile.)

Suppressed IE8 console log output. Closes #134. Closes #139.

Removed trailing whitespace.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #134 unhandled console.log in IE
2 participants
@Hiswe @julianshapiro