Fix(rtl): better rtl support (#1236)

[levyitay]

Added RTL detection for text in view mode.

[julianpoy]

Hi there! Thank you very much for the PR!

Will give this a test. I'm not super familiar, but would the dir property (https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/dir) be a better fit here rather than text-align?

[julianpoy]

So it looks like the same issue as reported in #1236 is still present with fraction symbols combined with numbers (3¾).

[levyitay]

@julianpoy True, but I believe it has nothing to do with RTL, I might be wrong, but it might worth doing different PR for that.
Let me know if you want me to add it to this PR or open a different one

[julianpoy]

No worries! If you're willing to look into the issue with fractions I'd welcome it!

For the issue of supporting RTL text when language is set to LTR (as well as LTR text when language is set to RTL) - I don't believe text-align or the isRtlText method is necessary. The browser has built-in RTL/LTR detection, but does so by default on the whole document. If you set dir="auto" on any element within the document, the browser will re-check that element for RTL/LTR content.

In summary: If you swap out all of the [dir]="..." and [style.text-align]="..." properties for dir="auto", RTL/LTR cross-compatibility should work!

[julianpoy]

Wanted to follow up and say I appreciate the PR, and am happy to merge it as-is since it works great in my testing! If you'd like to swap out for the dir="auto" I'll leave that up to you - just let me know.

[levyitay]

I'll give it a go in the weekend with dir="auto" I think it didn't work in my testing and report back

[levyitay]

@julianpoy moved everything to dir="auto" sorry it took a while.
I left the method that detects if the text is RTL or not for later usage if needed.

[levyitay]

@julianpoy should we merge it?

[julianpoy]

Hey there! Yep, can be merged. Thank you for the PR!