test: trcp recipes #1237
test: trcp recipes #1237
Conversation
|
Nice! Really excited to have a test setup for the tRPC side! I'll leave some comments shortly |
|
|
||
| it("creates a recipe", async () => { | ||
| const recipe = await trpc.recipes.createRecipe.mutate({ | ||
| title: "Sliced cucumber", |
There was a problem hiding this comment.
[non-blocking] For all of these values, I'd love for us to use the library faker.js to randomize the values
| }); | ||
|
|
||
| expect(recipe.id).toMatch( | ||
| /^[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-4[0-9a-fA-F]{3}-[89aAbB][0-9a-fA-F]{3}-[0-9a-fA-F]{12}$/, |
There was a problem hiding this comment.
I don't believe it's really necessary to test a pattern - as long as it returns a string, there's no reason to compare against a regex.
That said, if we still want to check against a regex anyway, we should move this regex to a util.
| await prisma.recipe.delete({ | ||
| where: { | ||
| id: recipe.id, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
This relies on some internal knowledge of the implementation of the mutation, rather than just testing behavior.
Since UUIDs are generated randomly there's really no need to cleanup between tests. Imo this can be removed.
| expect(recipe.id).toMatch( | ||
| /^[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-4[0-9a-fA-F]{3}-[89aAbB][0-9a-fA-F]{3}-[0-9a-fA-F]{12}$/, | ||
| ); | ||
| expect(recipe.title).toEqual("Sliced cucumber"); |
There was a problem hiding this comment.
I'd love to see a check using prisma to test that a recipe was indeed created in the DB.
packages/trpc/src/test/utils.js
Outdated
| export function randomEmail() { | ||
| return `${randomString(20)}@gmail.com`; | ||
| } | ||
|
|
||
| export function randomString(len) { | ||
| let chars = "abcdefghijklmnopqrstuvwxyz"; | ||
|
|
||
| let str = []; | ||
| for (let i = 0; i < len; i++) | ||
| str.push(chars.charAt(Math.floor(Math.random() * (chars.length - 1)))); | ||
|
|
||
| return str.join(""); | ||
| } |
There was a problem hiding this comment.
Rather than these, lets use faker.js
|
The tests in the tRPC side of the project should be TypeScript (no JavaScript on the tRPC side of the project). The tests should also sit next to the source code in question, rather than in a separate |
|
I see a CI failure, will investigate |
|
turned off tropic tests as part of circleCI as part of this commit, there were no test there anyway, so no loss I'd think update: I've poked around in the setup and I don't think I'd be able to start these up as part of the CI |
|
I've pushed a few commits to this PR. I've:
It can be merged in it's current state, but leaving open since this is your PR and I definitely want your sign-off prior to merge as it stands now. I also believe there's a lot we can expand on here (though this is absolutely a great foundation). To name a few, there are no tests for error cases, and no tests for things like labels & filtering which are critical codepaths for these recipe queries & mutations. |
| @@ -53,6 +53,13 @@ jobs: | |||
| - run: | |||
| name: migrate | |||
| command: npx prisma migrate dev | |||
| - run: | |||
| name: start api | |||
|
thank you a lot for your feedback @julianpoy |
this is just adding tests to Trcp projects
I know this is not part of pipeline, but could be added later on