Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild, add test & build scripts #2

Merged
merged 1 commit into from
Jul 13, 2015

Conversation

jameswomack
Copy link
Contributor

Hello @juliangruber! Thanks for publishing this module 🌟

I noticed this hasn't been updated in a while, and the constants exposed by Node have changed. I've opened this PR to reflect that.

Although the build script doesn't output the constants in the same order they were in before, I manually shifted them to make the diff as easy to ready as possible.

Other than re-running the build script, I've done the following:

  • Added a test (no test framework needed) to the package.json scripts block
  • Added the build script to the package.json scripts block
  • Updated the version number, engines and contributors block

Thanks!

@juliangruber
Copy link
Owner

lgtm, but can you please undo the changes to the package.json? especially the .engines limitation and .version

@jameswomack
Copy link
Contributor Author

@juliangruber Package changes removed. I used engine as I figured you'd want the constants to match the version of Node they came from. The version number change to 1.0.0 was to ensure someone relying on the older constants wouldn't get updated to this without wanting to (e.g. ^0.0.1 will update to 0.0.2).

@juliangruber
Copy link
Owner

You could be right about the node version problem, I'd say let's keep it simple though until this is acutally reported as a problem, so we know what we're dealing with.

juliangruber added a commit that referenced this pull request Jul 13, 2015
Rebuild, add test & build scripts
@juliangruber juliangruber merged commit 621da7d into juliangruber:master Jul 13, 2015
@juliangruber
Copy link
Owner

added you as a .contributor and released 1.0.0 :)

@jameswomack
Copy link
Contributor Author

I appreciate being able to contribute, thank you Julian.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants