Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2.0.5 can't create a github client #71

Closed
mscharley opened this issue Feb 26, 2024 · 3 comments · Fixed by #72
Closed

v2.0.5 can't create a github client #71

mscharley opened this issue Feb 26, 2024 · 3 comments · Fixed by #72

Comments

@mscharley
Copy link

Looks like there's some bad code in the big update PR (#70)

image
@juliangruber
Copy link
Owner

Strange: cd7907f passed, but from the next commit on it didn't any more

@juliangruber
Copy link
Owner

We need to add the build step to CI

@juliangruber juliangruber mentioned this issue Feb 26, 2024
Merged
juliangruber added a commit that referenced this issue Feb 26, 2024
@juliangruber
Fix GitHub API. Closes #71 (#72)
19528c0 
* test

* add build during ci

* update github api
@juliangruber
Copy link
Owner

Fixed in https://github.com/juliangruber/approve-pull-request-action/releases/tag/v2.0.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix GitHub API. Closes #71 juliangruber/approve-pull-request-action
2 participants
@juliangruber @mscharley