-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ManyLinux Binary Support #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Ok I just want to state that usually a Linux distribution has file support, i see that this is especially interesting for docker images. In line https://github.com/julian-r/python-magic/pull/2/files#diff-94c8e55ec0189c4c696c1bdd866df13eR181 you would exclude the already installed libraries support, i think.
Alright. Couldn't they just install Otherwise I can add a check to use native libraries first, and have this be a fallback. |
bump |
1 similar comment
bump |
I am now looking in howto maintain this fork, I'd actually prefer to keep it somehow close to the original project and already asked the maintainer about it. Let's see: If not i will setup a build pipline here, would you take care of the future linux bin releases? |
I've built file for linux using the manylinux docker image provided by python's manylinux project (https://github.com/pypa/manylinux) And added them to the build script.
I also modified magic.py to find the .so files on linux with virtual environments, since binary discovery is different on linux distributions.
In setup.py, I bumped the version number from 0.4.13 to 0.4.14, Updated the author list and emails, and added the linux object files to package_data.