Fix bug in at-derived macro parsing methods w/ unnamed arguments. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, this fixes method definitions like this: ```julia Salsa.@derived f(db::AbstractComponent, ::String) = "!" ```
|
@comnik i'm not sure why, but Github won't let me assign this review to you. Would you please take a look anyway? :) It was a simple change, just fixed a typo. Also, this should get simpler with the new API (what we're currently calling "minisalsa"). |
comnik
approved these changes
Apr 20, 2020
Before the previous commit, we were accidentally using `args` when we meant to be using `fullargs`. This commit just removes the `args` binding altogether so we don't make that mistake again. :)
ghost
merged commit
NHDaly
added a commit
that referenced
this pull request
May 4, 2020
- Merge pull request #1449 from RelationalAI/nhd-Salsa-downstream Downstream from https://github.com/RelationalAI-oss/Salsa.jl - Merge pull request #1485 from RelationalAI/compathelper/new_version/2… …020-03-28-00-14-03-879-1646924221 CompatHelper: bump compat for "PProf" to "1.0" - Merge pull request #1523 from RelationalAI/nhd-Salsa-display-dependen… …cy-graph Add Salsa inspect.jl to dump a dot graph / SVG from deps - Merge pull request #1568 from RelationalAI/nhd-Salsa-Workspace-perf Make Workspace prev_schema_page_id and schema_version not Salsa-tracked inputs - Merge pull request #1573 from RelationalAI/nhd-Salsa-Workspace-perf Add "SALSA_TRACE" logging for `get!()`; use `check_ENV` in Salsa. - Merge pull request #1590 from RelationalAI/nhd-Salsa-downstream Downstream #10 - Merge pull request #1628 from RelationalAI/nhd-salsa-tracing-fix Fix up Salsa trace to not dump the whole Input map in log.
NHDaly
added a commit
that referenced
this pull request
May 4, 2020
- Merge pull request #1449 from RelationalAI/nhd-Salsa-downstream Downstream from https://github.com/RelationalAI-oss/Salsa.jl - Merge pull request #1485 from RelationalAI/compathelper/new_version/2… …020-03-28-00-14-03-879-1646924221 CompatHelper: bump compat for "PProf" to "1.0" - Merge pull request #1523 from RelationalAI/nhd-Salsa-display-dependen… …cy-graph Add Salsa inspect.jl to dump a dot graph / SVG from deps Add "SALSA_TRACE" logging for `get!()`; use `check_ENV` in Salsa. - Merge pull request #1590 from RelationalAI/nhd-Salsa-downstream Downstream #10 - Merge pull request #1628 from RelationalAI/nhd-salsa-tracing-fix Fix up Salsa trace to not dump the whole Input map in log.
ghost
mentioned this pull request
NHDaly
added a commit
that referenced
this pull request
May 4, 2020
- Merge pull request #1449 from RelationalAI/nhd-Salsa-downstream Downstream from https://github.com/RelationalAI-oss/Salsa.jl - Merge pull request #1485 from RelationalAI/compathelper/new_version/2… …020-03-28-00-14-03-879-1646924221 CompatHelper: bump compat for "PProf" to "1.0" - Merge pull request #1523 from RelationalAI/nhd-Salsa-display-dependen… …cy-graph Add Salsa inspect.jl to dump a dot graph / SVG from deps Add "SALSA_TRACE" logging for `get!()`; use `check_ENV` in Salsa. - Merge pull request #1590 from RelationalAI/nhd-Salsa-downstream Downstream #10 - Merge pull request #1628 from RelationalAI/nhd-salsa-tracing-fix Fix up Salsa trace to not dump the whole Input map in log.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, this fixes method definitions like this:
Fixes #9