Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change LTS 1.6 -> 1.10 #290

Merged
merged 9 commits into from
Oct 9, 2024
Merged

Change LTS 1.6 -> 1.10 #290

merged 9 commits into from
Oct 9, 2024

Conversation

IanButterworth
Copy link
Member

No description provided.

@IanButterworth
Copy link
Member Author

This needs tests updating but it's also pulling 1.10.2 not the latest patch for some reason

@KristofferC

@DilumAluthge
Copy link
Member

Do we need to re-build versions.json? cc: @ararslan

@DilumAluthge
Copy link
Member

Do we need to re-build versions.json? cc: @ararslan

Just in case that's the issue, I have triggered a new re-build of versions.json: https://github.com/JuliaLang/VersionsJSONUtil.jl/actions/runs/11241255514

@ararslan
Copy link

ararslan commented Oct 8, 2024

I just checked the existing versions.json and it has 1.10.5

@DilumAluthge
Copy link
Member

but it's also pulling 1.10.2 not the latest patch for some reason

This one job (log) gets 1.10.5:

julia version 1.10.5

@DilumAluthge
Copy link
Member

Okay, so I checked the following CI logs:

  1. test (lts, x64, ubuntu-latest) (log)
  2. test (lts, x64, macOS-latest) (log)
  3. test (lts, x64, windows-latest) (log)
  4. test (lts, x86, ubuntu-latest) (log)
  5. test (lts, x86, windows-latest) (log)

And for all five of the above jobs, the CI logs show julia version 1.10.5 as the output for the Run julia --version step.

@KristofferC
Copy link
Contributor

The npm tests use this as the input versions

'1.10.0', '1.10.0-alpha1', '1.10.0-beta1', '1.10.0-beta2', '1.10.0-beta3', '1.10.0-rc1', '1.10.0-rc2', '1.10.0-rc3', '1.10.1', '1.10.2',
(not versions.json). So that has to be updated as well.

DilumAluthge
DilumAluthge previously approved these changes Oct 9, 2024
@IanButterworth IanButterworth marked this pull request as ready for review October 9, 2024 04:22
@IanButterworth IanButterworth requested a review from a team as a code owner October 9, 2024 04:22
@DilumAluthge DilumAluthge merged commit 1068b5e into master Oct 9, 2024
68 checks passed
@DilumAluthge DilumAluthge deleted the ib/lts_1.10 branch October 9, 2024 04:30
@DilumAluthge
Copy link
Member

This has been released in v2.6.0.

The v2.6.0 tag has been created, and pushed, and the corresponding GitHub Release has been created: https://github.com/julia-actions/setup-julia/releases/tag/v2.6.0

The v2 tag has been force-updated.

The latest tag has been force-updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants