Skip to content

Commit

Permalink
Fix the Apple Silicon (macOS aarch64 / arm64) URLs for Julia nigh…
Browse files Browse the repository at this point in the history
…tly (#220)

* fix aarch64 urls for nightly

* rebuild js for aarch64 nightly

* test nightly on apple m1 (aarch64)

* Run on more macOS versions, and add a few comments

---------

Co-authored-by: Dilum Aluthge <[email protected]>
  • Loading branch information
benlorenz and DilumAluthge authored Feb 11, 2024
1 parent bb12998 commit 0f702cc
Show file tree
Hide file tree
Showing 3 changed files with 34 additions and 5 deletions.
9 changes: 8 additions & 1 deletion .github/workflows/example-builds-nightly-defaultarch.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,14 @@ jobs:
fail-fast: false
matrix:
julia-version: [nightly, 1.10-nightly]
os: [ubuntu-latest, macOS-latest, windows-latest]
os:
- ubuntu-latest
- windows-latest
- macos-11 # Intel
- macos-12 # Intel
- macos-13 # Intel
- macos-14 # Apple Silicon
- macos-latest # Currently Intel, but will probably point to Apple Silicon in the future

steps:
- uses: actions/checkout@v4
Expand Down
17 changes: 15 additions & 2 deletions lib/installer.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 11 additions & 2 deletions src/installer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -128,10 +128,19 @@ function getNightlyFileName(arch: string): string {
} else if (osPlat == 'darwin') {
if (arch == 'x86') {
throw new Error('32-bit Julia is not available on macOS')
} else if (arch == 'aarch64') {
versionExt = '-macaarch64'
} else {
versionExt = '-mac64'
}
versionExt = '-mac64'
} else if (osPlat === 'linux') {
versionExt = arch == 'x64' ? '-linux64' : '-linux32'
if (arch == 'x86') {
versionExt = '-linux32'
} else if (arch == 'aarch64') {
versionExt = '-linux-aarch64'
} else {
versionExt = '-linux64'
}
} else {
throw new Error(`Platform ${osPlat} is not supported`)
}
Expand Down

0 comments on commit 0f702cc

Please sign in to comment.