Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add depot caching #25

Merged
merged 1 commit into from
Dec 2, 2023
Merged

add depot caching #25

merged 1 commit into from
Dec 2, 2023

Conversation

IanButterworth
Copy link
Member

A lot of time is spent precompiling JuliaFormatter vs. time running the formatter.
It might be worth always caching the depot

@IanButterworth
Copy link
Member Author

No repo CI?

@domluna
Copy link
Collaborator

domluna commented Nov 28, 2023

is CI for github actions a thing?

@IanButterworth
Copy link
Member Author

One thought on this PR though. It may be better to recommend adding the cache action in the user's yml, so that they can also grant the necessary permissions for cache deletion https://github.com/julia-actions/cache#usage

@domluna
Copy link
Collaborator

domluna commented Nov 28, 2023

I'm not sure. I don't really have a preference. I haven't used this much this I initially made it so I'll defer to your judgement on the matter.

@lgoettgens
Copy link

Pinging @hyrodium for an opinion, since they re-wrote the action recently.

@hyrodium
Copy link
Collaborator

hyrodium commented Dec 2, 2023

I'm not familiar with caching and CI settings for GitHub Actions, but this proposal seems reasonable. Is there any reason for keeping the draft?

@IanButterworth IanButterworth marked this pull request as ready for review December 2, 2023 15:11
@IanButterworth
Copy link
Member Author

RTM from my perspective. Having CI would be good though, but I'll leave that up to the maintainers

@domluna
Copy link
Collaborator

domluna commented Dec 2, 2023

ok im gonna merge it then would i also need to tag a new release?

@domluna domluna merged commit 2331fb5 into master Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants