-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add depot caching #25
Conversation
No repo CI? |
is CI for github actions a thing? |
One thought on this PR though. It may be better to recommend adding the cache action in the user's yml, so that they can also grant the necessary permissions for cache deletion https://github.com/julia-actions/cache#usage |
I'm not sure. I don't really have a preference. I haven't used this much this I initially made it so I'll defer to your judgement on the matter. |
Pinging @hyrodium for an opinion, since they re-wrote the action recently. |
I'm not familiar with caching and CI settings for GitHub Actions, but this proposal seems reasonable. Is there any reason for keeping the draft? |
983a3af
to
991da06
Compare
991da06
to
33c22fa
Compare
RTM from my perspective. Having CI would be good though, but I'll leave that up to the maintainers |
ok im gonna merge it then would i also need to tag a new release? |
A lot of time is spent precompiling JuliaFormatter vs. time running the formatter.
It might be worth always caching the depot