Complete support for user secrets #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anvial
approved these changes
Nov 30, 2023
|
/merge |
Merged
jujubot
added a commit
that referenced
this pull request
Nov 30, 2023
#988 ## What's Changed The main contribution of this release is the user secrets that's released as a part of Juju 3.3. * Free pyblijuju from relying on juju client when connecting to a controller by @cderici in #984 * Handle FileNotFoundError on current_controller() by @DanielArndt in #937 * Add support for adding user secrets by @cderici in #986 * Complete support for user secrets by @cderici in #987 #### Notes & Discussion JUJU-5079
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the continuation of #986, completing the support for user secrets on pylibjuju by adding
update_secret,remove_secret,grant_secretandrevoke_secret.QA Steps
Added integration tests for all of these so they can be individually ran:
All CI tests need to pass.
Notes & Discussion
JUJU-5093