Fix juju config directory location pointed by XDG_DATA_HOME #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XDG_DATA_HOME is supposed to point to the parent directory for applications. We were incorrectly setting that as Juju config dir.
cderici
added
hint/2.9
jack-w-shaw
reviewed
Oct 26, 2023
|
/merge |
cderici
removed
the
area/forward-port
jujubot
added a commit
that referenced
this pull request
Oct 26, 2023
#976 #### Description Forward port of #975 XDG_DATA_HOME is supposed to point to the parent directory for applications. We were incorrectly setting that as Juju config dir. #### QA Steps No operational logic changes. There's one CI failure on the master branch about add manual machine ssh that's unrelated to this change, that one's aside, all the others need to be passing.
Merged
jujubot
added a commit
that referenced
this pull request
Oct 26, 2023
#979 ## What's Changed * Deploy by revision on 2.9 by @cderici in #957 * Application refresh with resources by @cderici in #960 * Improve jujudata to find controller name by endpoint by @cderici in #964 * Allow switch kwarg in refresh to switch to local charms by @jack-w-shaw in #968 * Parse charm URLs consistantly for local charms by @jack-w-shaw in #969 * Fix juju config directory location pointed by XDG_DATA_HOME by @cderici in #975 * [JUJU-4779] Switch to local properly by @jack-w-shaw in #977 #### Notes & Discussion JUJU-4850 [JUJU-4779]: https://warthogs.atlassian.net/browse/JUJU-4779?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
jujubot
added a commit
that referenced
this pull request
Jan 9, 2024
#993 #### Description The walrus operator (`:=`) was introduced in Python 3.8, the use of it in the `2.9` branch breaks python 3.6 compatibility which is the version used in Ubuntu 18.04 (Bionic). https://docs.python.org/3/whatsnew/3.8.html#assignment-expressions #### QA Steps 1. Install python-libjuju in python 3.6 2. python3 -c "import juju.utils" ``` virtualenv -p /usr/bin/python3.6 /tmp/myvenv source /tmp/myvenv/bin/activate python3 setup.py install python3 -c "import juju.utils" ``` All CI tests need to pass. #### Notes & Discussion This regression was introduced by #975
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
XDG_DATA_HOME is supposed to point to the parent directory for applications. We were incorrectly setting that as Juju config dir.
QA Steps
No operational logic changes. All CI tests need to pass.
Notes & Discussions
Thanks @jameinel for pointing this out!