Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme and add some docstrings for functions #873

Merged
merged 3 commits into from
Jun 7, 2023

Conversation

cderici
Copy link
Contributor

@cderici cderici commented Jun 5, 2023

Description

Small change that updates the example in the readme and adds some docstrings for model.py and bundle.py.

QA Steps

No change in any functionality, so no QA is needed. Just some proof read, maybe.

@cderici cderici requested a review from juanmanuel-tirado June 7, 2023 15:30
Copy link
Contributor

@juanmanuel-tirado juanmanuel-tirado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M

@cderici
Copy link
Contributor Author

cderici commented Jun 7, 2023

/merge

@jujubot jujubot force-pushed the cleaning-tidying-up branch from cd8a318 to 263fa3e Compare June 7, 2023 18:01
@cderici
Copy link
Contributor Author

cderici commented Jun 7, 2023

/merge

@jujubot jujubot merged commit d75b1f9 into juju:master Jun 7, 2023
jujubot added a commit that referenced this pull request Jul 20, 2023
#920

## What's Changed
* Update readme and add some docstrings for functions by @cderici in #873
* Forward port subordinate utils by @cderici in #880
* [JUJU-3952] Revisit access control levels by @cderici in #882
* [JUJU-3999] Avoid parsing endpoint for overlay offers by @cderici in #887
* Forward port upgrade resource fixes in app refresh by @cderici in #889
* [JUJU-4076] Rename `wait_for_units` and make semantics clearer by @cderici in #890
* Stabilize sphinx build on RTD by @cderici in #899
* Move test utils into a separate module by @cderici in #903
* Remove title prefixes from issue templates by @cderici in #904
* [JUJU-4048] Use GetChangesMapArgs for bundle changes by @jack-w-shaw in #907
* Forward ports from 2.9 to 3.x by @cderici in #910
* Remove ceiling on pyyaml version by @cderici in #918

[JUJU-3952]: https://warthogs.atlassian.net/browse/JUJU-3952?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[JUJU-3999]: https://warthogs.atlassian.net/browse/JUJU-3999?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[JUJU-4076]: https://warthogs.atlassian.net/browse/JUJU-4076?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[JUJU-4048]: https://warthogs.atlassian.net/browse/JUJU-4048?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants